refactor: Actions and Inputs render as JsFunctions#24433
Open
Artur- wants to merge 6 commits into
Open
Conversation
Replace appendStatement(JsBuilder, StringBuilder) on Action with render(JsBuilder): JsFunction. Replace Input.appendExpression with Input.toJs(JsBuilder): JsFunction returning the input's value when invoked. Each Action ships as its own JsFunction (body + captures); Trigger composes them as captures of a tiny parent JsFunction whose body is just $0(event);$1(event);... PromiseAction wraps the subclass JsFunction with OBSERVE_PROMISE via captures instead of string concatenation. Eliminates hand-escaped JS literals in action bodies — strings and Element refs go through JsFunction's capture mechanism, which Jackson- encodes on the wire. Removes the "this" special-case for the host element: the host is captured the same way as any other Element. JsBuilder shrinks to just the render-time context (trigger() accessor) plus a static json() helper kept for Trigger.installJs() (a raw String, not a JsFunction).
Artur-
force-pushed
the
action-input-jsfunc
branch
from
5bb8b54 to
f5b194e
Compare
# Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/trigger/internal/CopyTextToClipboardAction.java # flow-server/src/test/java/com/vaadin/flow/component/trigger/internal/WriteToClipboardActionTest.java
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace appendStatement(JsBuilder, StringBuilder) on Action with render(JsBuilder): JsFunction. Replace Input.appendExpression with Input.toJs(JsBuilder): JsFunction returning the input's value when
invoked.
Each Action ships as its own JsFunction (body + captures); Trigger composes them as captures of a tiny parent JsFunction whose body is just $0(event);$1(event);... PromiseAction wraps the subclass JsFunction with OBSERVE_PROMISE via captures instead of string concatenation.
Eliminates hand-escaped JS literals in action bodies — strings and Element refs go through JsFunction's capture mechanism, which Jackson-encodes on the wire. Removes the "this" special-case for the host element: the host is captured the same way as any other Element.
JsBuilder shrinks to just the render-time context (trigger() accessor) plus a static json() helper kept for Trigger.installJs() (a raw String, not a JsFunction).