feat: add virtual-aware component tree traversal helpers#24408
Open
Artur- wants to merge 9 commits into
Open
Conversation
Adds ComponentUtil.getAllChildren and ComponentUtil.streamDescendants. Unlike Component.getChildren, these include components attached as virtual children (slotted helpers like addToFooter, overlays attached to the UI, the client-side routing wrapper), so tools that need a complete component tree no longer have to reach into internal APIs such as VirtualChildrenList.
StateNode.getFeatureIfInitialized throws when the node isn't configured for the requested feature, and text-node StateNodes created by BasicTextElementStateProvider don't have VirtualChildrenList. The recursive descent in getAllChildren and streamDescendants therefore crashed when a non-component wrapper element had a text-node child. Mirror the hasFeature guard used by Element.informChildrenOfStateChange.
mcollovati
requested changes
May 22, 2026
Also fix the error message: Component.wrapAndMap does not exist; the canonical way to create a Component that maps back to its Element is Component.from(Element, Class). The identical wording in the existing getChildren and getParent messages references the same missing method, but cleaning those up is out of scope for this PR.
mcollovati
requested changes
May 25, 2026
| } | ||
|
|
||
| @Test | ||
| public void wrappedComponentGetAllChildren() { |
Collaborator
There was a problem hiding this comment.
Just looking at the code, it is not clear what we are testing. Can we rename the test method to describe the use case? Or add a comment if method rename is not feasible.
Merged
2 tasks
Renames wrappedComponentGetAllChildren to getAllChildren_throwsForWrappedComponent and explains why Element.as puts a Component in a state where getAllChildren cannot resolve children.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ComponentUtil.getAllChildren and ComponentUtil.streamDescendants. Unlike Component.getChildren, these include components attached as virtual children (slotted helpers like addToFooter, overlays attached to the UI, the client-side routing wrapper), so tools that need a complete component tree no longer have to reach into internal APIs such as VirtualChildrenList.