test: mark tapscript/pushmaxlimit as non-standard for BIP-110 reduced…#3
Merged
Merged
Conversation
… push size limit The tapscript/pushmaxlimit spender uses a leaf script with a 520-byte push (MAX_SCRIPT_ELEMENT_SIZE). Since SCRIPT_VERIFY_REDUCED_DATA is included in STANDARD_SCRIPT_VERIFY_FLAGS, the 256-byte reduced push limit (MAX_SCRIPT_ELEMENT_SIZE_REDUCED) is enforced as mempool policy. This causes the 520-byte push to be rejected as non-standard. Without standard=False, the test intermittently tries to submit this spender to the mempool expecting acceptance, depending on whether the randomly chosen tx version and co-inputs happen to all be standard. On the upstream Knots-based branch (bip110-v0.3), this fix was introduced by the match_more_datacarrier merge (Bitcoin Core PR 28408), which independently made large tapscript pushes non-standard via datacarrier size filtering. On this Core-based branch, the same fix is needed because SCRIPT_VERIFY_REDUCED_DATA has the same effect. Reproduces with: --randomseed=823027376919141336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… push size limit
The tapscript/pushmaxlimit spender uses a leaf script with a 520-byte push (MAX_SCRIPT_ELEMENT_SIZE). Since SCRIPT_VERIFY_REDUCED_DATA is included in STANDARD_SCRIPT_VERIFY_FLAGS, the 256-byte reduced push limit (MAX_SCRIPT_ELEMENT_SIZE_REDUCED) is enforced as mempool policy. This causes the 520-byte push to be rejected as non-standard.
Without standard=False, the test intermittently tries to submit this spender to the mempool expecting acceptance, depending on whether the randomly chosen tx version and co-inputs happen to all be standard.
On the upstream Knots-based branch (bip110-v0.3), this fix was introduced by the match_more_datacarrier merge (Bitcoin Core PR 28408), which independently made large tapscript pushes non-standard via datacarrier size filtering. On this Core-based branch, the same fix is needed because SCRIPT_VERIFY_REDUCED_DATA has the same effect.
Reproduces with: --randomseed=823027376919141336