mgradm: Allow diskcheck env vars into containers (bsc#1270033)#816
Open
mbussolotto wants to merge 2 commits into
Open
mgradm: Allow diskcheck env vars into containers (bsc#1270033)#816mbussolotto wants to merge 2 commits into
mbussolotto wants to merge 2 commits into
Conversation
mbussolotto
force-pushed
the
diskcheck_fix
branch
from
9ba1dc6 to
850ae6d
Compare
mbussolotto
force-pushed
the
diskcheck_fix
branch
from
850ae6d to
f1a1935
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates mgradm’s generated systemd unit templates to allow injecting additional Podman --env/-e flags (intended for “diskcheck” environment variables) into the container podman run invocation.
Changes:
- Adds a new
${PODMAN_EXTRA_ENV_VAR}expansion point to the Uyuni server systemd service template. - Adds the same
${PODMAN_EXTRA_ENV_VAR}expansion point to the PostgreSQL (uyuni-db-server) systemd service template. - Adds a changelog fragment describing the change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
uyuni-tools.changes.mbussolotto.diskcheck_fix |
Adds a changelog fragment for the diskcheck env-var passthrough feature. |
mgradm/shared/templates/templates_test.go |
Updates expected server unit rendering snapshots to include ${PODMAN_EXTRA_ENV_VAR}. |
mgradm/shared/templates/serviceTemplate.go |
Injects ${PODMAN_EXTRA_ENV_VAR} into the server podman run command. |
mgradm/shared/templates/pgsqlServiceTemplate.go |
Injects ${PODMAN_EXTRA_ENV_VAR} into the DB podman run command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mbussolotto
force-pushed
the
diskcheck_fix
branch
from
fc18e34 to
2f1c030
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
as title
Codespace
Check if you already have a running container clicking on
Test coverage
No tests
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/31099
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!