Skip to content

Add explicit permissions to GitHub Actions workflows #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szachovy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add explicit permissions to GitHub Actions workflows #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

name: Build

permissions:
contents: read

on:
pull_request:
types:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/changelogs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
# SPDX-License-Identifier: Apache-2.0
name: Changelogs

permissions:
contents: read

Check notice

Code scanning / SonarCloud

Read permissions should be defined at the job level Low

Move this read permission from workflow level to job level. See more on SonarQube Cloud

Check warning on line 7 in .github/workflows/changelogs.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this read permission from workflow level to job level. 


See more on https://sonarcloud.io/project/issues?id=uyuni-project_uyuni-tools&issues=AZ4BievVllEXtoPR50po&open=AZ4BievVllEXtoPR50po&pullRequest=784
pull-requests: write

Check notice

Code scanning / SonarCloud

Write permissions should be defined at the job level Low

Move this write permission from workflow level to job level. See more on SonarQube Cloud

Check warning on line 8 in .github/workflows/changelogs.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Move this write permission from workflow level to job level. 


See more on https://sonarcloud.io/project/issues?id=uyuni-project_uyuni-tools&issues=AZ4BievVllEXtoPR50pp&open=AZ4BievVllEXtoPR50pp&pullRequest=784

on:
push:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/git-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

name: Git Checks

permissions:
contents: read

on: [pull_request]

jobs:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/mingo_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

name: Build with oldest go

permissions:
contents: read

on:
pull_request:
types:
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/prebuilt_devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
# SPDX-License-Identifier: Apache-2.0

name: 'pre-built devcontainer'

permissions:
contents: read
id-token: write
packages: write

on:
push:
branches:
Expand All @@ -11,10 +17,6 @@ on:
jobs:
devcontainer-build-and-push:
runs-on: ubuntu-latest
permissions:
contents: read
id-token: write
packages: write
steps:
- name: Checkout
id: checkout
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/reuse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

name: REUSE Compliance Check

permissions:
contents: read

on:
push:
branches:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/vulncheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

name: Vulnerability check

permissions:
contents: read

on:
pull_request:
types:
Expand Down
Loading