Skip to content

update node versions#183

Open
maishathasin wants to merge 5 commits into
mainfrom
node_version
Open

update node versions#183
maishathasin wants to merge 5 commits into
mainfrom
node_version

Conversation

@maishathasin

Copy link
Copy Markdown
Member

Notion ticket link

Ticket Name

Implementation description

  • Updating node versions from 14.5.5 to 16.0.0

Steps to test

  1. Build docker image for frontend and backend

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions

github-actions Bot commented Nov 27, 2023

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit a21fb73):

https://uw-blueprint-starter-code--pr183-node-version-fpa2yx7u.web.app

(expires Wed, 06 Dec 2023 04:12:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8a9d9b9ea27110b294ec3954ff89dab270e34c45

@billcui57 billcui57 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just have a question

Comment thread .github/workflows/firebase-hosting-pull-request.yml Outdated

@billcui57 billcui57 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants