fix: enable TLS certificate verification across all scanners and crawler#1736
fix: enable TLS certificate verification across all scanners and crawler#1736namann5 wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
utksh1
left a comment
There was a problem hiding this comment.
The TLS-verification goal is important, but this PR needs cleanup before merge:\n\n1. Split out unrelated packaging/CI files from the TLS fix. The title says TLS verification, but the PR also changes dependency declarations and CI-related files.\n2. Add focused tests for the new verification setting / behavior so we know scanners and crawler keep working with verification enabled by default and configurable overrides.\n3. Keep the PR scoped to the actual TLS-certificate verification change only.\n\nOnce the scope is clean and there is direct regression coverage, this will be much easier to merge.
SECUSCAN-001 (Critical): TLS certificate verification was globally disabled with verify=False in 4 locations (crawler, XSS scanner, API scanner, network vulnerability scanner), leaving all outbound HTTPS connections vulnerable to MITM attacks. Added verify_ssl: bool = True to Settings (configurable via SECUSCAN_VERIFY_SSL env var) and updated all httpx.AsyncClient calls to reference it.
2dffe77 to
b736888
Compare
|
Scope cleaned — The branch fix/tls-verification-disabled now contains only the TLS-certificate verification change (1 commit, 5 files, +10/-4 lines). The unrelated commit (deps sync + CodeQL workflow) was already isolated on fix/missing-dependencies-and-codeql.
|
Description
Fixes critical security vulnerability where TLS certificate verification was globally disabled across the entire scanning pipeline.
Changes
Impact
All outbound HTTPS connections now verify TLS certificates by default, preventing Man-in-the-Middle attacks against scanner operations. Operators can still disable verification for development via \SECUSCAN_VERIFY_SSL=false.
Verification
uff check)
Closes #1735