fix(frontend): remove exhaustive-deps suppression from Findings virtualizer effect#1723
Merged
utksh1 merged 1 commit intoJul 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
eslint-disable react-hooks/exhaustive-depssuppression on the Findings virtualizer scroll effect. The effect previously readselectedFinding,virtualRows, andvirtualizerfrom render scope while only depending onselectedFindingId, which could leave stale virtualizer/row data after filtering or sorting. Fixed by keepingselectedFindingIdas the only reactive dependency, whilevirtualRowsandvirtualizerare now read through refs kept fresh via separate no-dependency-array effects, satisfying exhaustive-deps without over-firing the scroll on every filter/sort.Related Issues
Closes #1407
Type of Change
How Has This Been Tested?
scrollToIndexis called with the correct post-sort index rather than a stale pre-sort one.npm run test- 531/531 passing.npm run typecheck- no errors.npm run build- succeeds (pre-existing vendor chunk size warning is unrelated to this change).scripts/check-artifacts.sh- all clear, no generated artifacts staged.Checklist