chore: migrate to ESM#20
Merged
Merged
Conversation
Switch from CommonJS to ES modules to unblock major dependency upgrades. @actions/core v3, @actions/exec v3, and @actions/tool-cache v4 all dropped CJS support (exports field is import-only), which caused ncc to fail. - Add "type": "module" to package.json - Update tsconfig: module/moduleResolution -> nodenext, target -> ES2022 - Replace require.main === module guard with import.meta.url equivalent - ncc now compiles to ESM (confirmed locally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks all failing major dependency bumps (#11, #12, #14).
Root cause:
@actions/corev3,@actions/execv3, and@actions/tool-cachev4 all dropped CJS support — theirexportsfield only exposes"import".@vercel/ncc(webpack-based) can't bundle pure-ESM packages from a CJS context, causing the build step to fail for all three.Changes:
"type": "module"topackage.jsontsconfig.json:module/moduleResolution→nodenext,target→ES2022require.main === moduleentry-point guard withimport.meta.urlequivalentnccnow compiles to ESM (Compiling file index.js into ESM)All 49 tests pass, build succeeds, lint clean.