Fixed data length check and add padding - #24
Open
richardmoser wants to merge 1 commit into
Open
Conversation
Fix data padding logic in machine_report.sh Changed the if condition ragarding data_len in PRINT_DATA() from `data_len >= MAX_DATA_LEN` to `data_len > MAX_DATA_LEN` to correct bar graph padding. Also added a line to pad the data after it is truncated in the same if block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a data padding issue in the
PRINT_DATA()function that appears on Ubuntu 25.10 and possibly other systems.Changed the if condition regarding data_len in PRINT_DATA() from
data_len >= MAX_DATA_LENtodata_len > MAX_DATA_LENto correct bar graph padding. Also added a line to pad the data after it is truncated in the same if block.See Issue #23 for more information about the error. (I can't seem to link the two either due to permissions or my own level of knowledge)