Fix JSON logging from standard error#1145
Merged
Merged
Conversation
toinehartman
force-pushed
the
fix/language-server-logging
branch
from
21c9a4a to
a7ab8e7
Compare
The update of `vscode-languageclient` to `10.x` in #1114 changed logging behaviour, since the logger is now a `LogOutputChannel` by default (instead of an `OutputChannel`).
toinehartman
force-pushed
the
fix/language-server-logging
branch
from
a7ab8e7 to
1db58d4
Compare
toinehartman
changed the title
|
DavyLandman
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update of
vscode-languageclientto10.xin #1114 changed logging behaviour, since the logger is now aLogOutputChannelby default (instead of anOutputChannel- microsoft/vscode-languageserver-node#1630).Where before, we received
OuptuChannel::appendcalls for LOG4J messages from the language server, this has changed toLogOutputChannel::errorcalls, enabled by the more refined logger type in the client. This is probably because LOG4J uses the standard error stream.