feat(beck): theme the zoom lightbox with host CSS variables#68
Merged
Conversation
Replace the hardcoded rgb(0 0 0) scrim with the host --color-base-* ramp: a washed-out color-mix backdrop (blur + desaturate) with an @starting-style entrance transition, the close button restyled on the same ramp as the zoom button, and the cloned SVG wrapped in an opaque theme-surface panel so the diagram reads solid against the blur. Dark mode keys off [data-theme="dark"], matching the Beck SVG.
|
🛰️ Docs preview: https://pr-68.pennington-dev.pages.dev Rebuilt on every push to this PR; torn down when it closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rgb(0 0 0/.25)scrim with the host--color-base-*ramp:color-mixof base-50 (light) / base-950 (dark) over transparent, withblur(12px) saturate(0.1)so the page washes out behind the diagram@starting-styleblock so the backdrop transition has a from-state (::backdropis newly rendered on every open; the dialog is removed on close, so the cue is entrance-only).beck-zoombutton — its white-on-black styling was designed for a dark scrim and clashed with the new washed-out light backdrop.beck-lightbox-panelgiving the zoomed diagram an opaque theme surface (base-50/base-950 + border + shadow); the surface lives on a wrapper rather than the<svg>because padding on an auto-sized SVG box skews its intrinsic-ratio sizingDark mode keys off
[data-theme="dark"]— the same signal the Beck SVG itself uses.Test plan
dotnet test --filter FullyQualifiedName~BeckZoomHeadContributor(4 passed)