feat: track accept header dimension#1
Merged
Conversation
Uses after for the analytics tracking as recommended by Next.js https://nextjs.org/docs/app/api-reference/functions/after
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after()for proxy analytics trackingNotes
main, which already drops unknown-agent requests.Testing
bun run typecheckbun test src/duration.test.ts src/time.test.ts src/hash.test.ts src/request.test.tsbun test(fails becauseUPSTASH_REDIS_REST_URLandUPSTASH_REDIS_REST_TOKENare not configured in this environment; non-Redis tests, including the new request tests, pass)Summary by cubic
Switches analytics in the Next.js proxy to
after()so tracking never blocks responses, and addsacceptheader tracking as a new dimension across ingestion and schema.New Features
Acceptheader asacceptin events and the index schema.Migration
proxy.ts, replaceawait analytics.track(request)withafter(() => analytics.track(request))fromnext/server.Written for commit e604040. Summary will update on new commits.