feat: squash commit of krummbar/bruno-run-action#1
Open
krummbar wants to merge 1 commit into
Open
Conversation
commit 0580b4cbe3cbbe5c9e25eb2476512b0d86c379ef
Author: Max Bauer <krummbar@pm.me>
Date: Sun Sep 8 21:05:35 2024 +0200
fix: check bool arguments for actual true value
commit b02789d291e7f2b13463ff1f09989137822d6baa
Author: Max Bauer <krummbar@pm.me>
Date: Sun Sep 8 21:05:19 2024 +0200
fix: remove default for sandbox
commit fba9bbff90f50d52081dac8a3e0e5ae5f0d7fdf8
Author: Max Bauer <krummbar@pm.me>
Date: Sun Sep 1 08:16:03 2024 +0200
fix(lint): .github/workflows/ci.env
commit 839163a3bf7d57ff6f418fec41be99d7662088ab
Author: Max Bauer <krummbar@pm.me>
Date: Sun Sep 1 08:11:41 2024 +0200
feat: add --ignore-truststore and --sandbox arguments
commit 5f0c216a37284a12095c9508ff6519e446b59906
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sat Aug 31 10:58:31 2024 +0200
build(deps): bump super-linter/super-linter from 6 to 7 (usebruno#4)
* build(deps): bump super-linter/super-linter from 6 to 7
Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 6 to 7.
- [Release notes](https://github.com/super-linter/super-linter/releases)
- [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md)
- [Commits](super-linter/super-linter@v6...v7)
---
updated-dependencies:
- dependency-name: super-linter/super-linter
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* fix .github/workflows/ci.env
* fix prettier to ignore bruno collection
* fix yaml formatter
* fix action.yaml formatter issues
* fix .prettierrc.json issues
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Max Bauer <krummbar@pm.me>
commit 59483ab28eb9fd66daf79f68e72a6c13f7956afc
Author: Max Bauer <krummbar@pm.me>
Date: Sat Jul 20 14:43:28 2024 +0200
feat: add csv-file-path input argument (usebruno#3)
feat: add output parameter bru-version
feat: add input argumentcsv-file-path
chore: simplified bruno collection used during CI
commit 362f5c8e1ca47f20c6c3b9706030af6c4dc035fc
Author: Max Bauer <krummbar@pm.me>
Date: Sun Jul 14 06:54:49 2024 +0200
feat: pin bru cli to version 1.x
commit 431a511202f8f93595726f9d6a6ff372a17caf43
Author: Max Bauer <krummbar@pm.me>
Date: Sun Jun 30 08:07:46 2024 +0200
feat: change camelCase to kebap-case (usebruno#2)
* feat: change to camelCase to kebap-case
commit 4e11dfb9e7dbde72e2dce3559a9d548c991e2ab5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun Jun 30 08:01:09 2024 +0200
Bump docker/build-push-action from 5 to 6 (usebruno#1)
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v5...v6)
---
updated-dependencies:
- dependency-name: docker/build-push-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
commit 7be7ca62a0705f6c1288e1b0631c7416634b2d28
Author: Max Bauer <krummbar@pm.me>
Date: Sun Jun 9 07:23:50 2024 +0200
feat: enable cacert & updated docs
commit 77c7c7959811bdd60740fdafc5cce55cdb2405cb
Author: Max Bauer <krummbar@pm.me>
Date: Sat Jun 8 07:33:35 2024 +0200
optimize entrypoint.sh
commit 14d481bd0e681abc965f29dc0fb775c52975e4e6
Author: Max Bauer <krummbar@pm.me>
Date: Tue Jun 4 22:53:25 2024 +0200
use bruno sanity test environment for cicd
commit 12e3a1addb4fd3b3ba4b6fc8375c0d86afa904ed
Author: Max Bauer <krummbar@pm.me>
Date: Sun Jun 2 09:08:07 2024 +0200
inital draft
commit 417d61c189de558a9bc8347bf8efbdb377cb10d3
Author: Max Bauer <max.krumrein@proton.me>
Date: Thu May 30 21:09:21 2024 +0200
initial commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contains the code of krummbar/bruno-run-action. Commit history is squashed into a single commit. If preferred I can also preserve the current history.
The current code reflects the features for bru run cli
v1.26.2.Let me know when you want to publish this action. I'll archive my source repo then and add a reference to the new repository.
Remark
Versioning
For future development we'll need to decide how to proceed with versioning of this action. Currently the bru cli version is backed into the Dockerfile
1.x. So it'll use the most recent version of version 1.I'm not sure what the best approach is. I could imagine introducing version branches that pin to specific bru cli versions and use a version tag
v1that also points to the latest commit.branch/v1.20branch/v1.26While the tag
v1always points to the most recent features. A version branch references then the specified version in the Dockerfile.However this could introduce increased maintenance effort if a patch is required to all those versions.
Alternative approach is to remove the installation step from the Dockerfile and move it to the entrypoint.sh script and use a optional version input argument for the action.
Effectively users would then be able to specify bru cli version when including it in their actions. But all the other action input arguments would need to be replaced with a generic one.
Going down this path effectively makes all the other input arguments obsolete.
This is how the action could look like in workflows
Branch/Version based approach
Provide version as argument
Maybe you have some better ideas how to proceed here. Just wanted to leave my thoughts on that topic.