chore(lint): run all CI linters locally via make targets#563
Conversation
✅ Deploy Preview for urunc canceled.
|
|
Hello @IrvingMg , I have tested this out and it works well. A couple of questions / comments:
|
|
Hey @cmainas, thanks for giving it a try. About keeping the official actions in CI, that sounds good to me. We can keep this issue focused on local development. Since the custom npm image should be rebuilt when something changes in the linters directory, the risk of differences between CI and local setup should stay low. About where the linters should live, those configs are still used by the CI workflows, so they need to stay close to CI in some way. It probably makes sense to keep them in .github/linters/ so we don’t need to update workflow paths without a good reason. That said, I don’t have a strong opinion here. |
|
Hello @IrvingMg , sounds good. Let;s rebase over main so we can merge. |
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
✅ Deploy Preview for urunc canceled.
|
|
Hi @cmainas, Sorry for the late reply. I’ve rebased the branch. |
Description
Add per-tool
make lint_*targets and amake lintumbrella that run all four CI linters (golangci-lint, cspell, commitlint, license-eye) locally via containers, so contributors can catch all CI lint failures before pushing.Notes:
linters-npm:v0.1.0).Related issues
maketarget to run all CI linters locally #491How was this tested?
Ran all lint targets together via
make lint, and individually usingmake lint_*.LLM usage
Claude Opus 4.6
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).