fix(ci): propagate closing keywords to merge PR body#559
Conversation
✅ Deploy Preview for urunc canceled.
|
|
Hello @IrvingMg , just to keep you updated, I will need to test this in a forked repository, so it might take some time for the review. |
|
Hello @IrvingMg , I played around a bit with this PR. Unfortunately, It seems we are still missing something and the issues do not close automatically. I have create anew repository to test these changes https://github.com/urunc-dev/urunc_test . The changes of this PR have have addedd the respective message in urunc-dev/urunc_test#9 but the issue is still open. In the repository setting the "Auto-close issues with merged linked pull requests " is enabled. |
|
Thanks for testing this, @cmainas! Looking at this discussion (https://github.com/orgs/community/discussions/24869#discussioncomment-3245678), it seems the missing piece might be the permissions of urunc-bot. Since the bot is the one merging the PR, GitHub treats it as the user who should also close the issue. However, from the output of "permissions": {
"actions": "write",
"administration": "write",
"contents": "write",
"metadata": "read",
"pull_requests": "write",
"workflows": "write"
}So it probably can’t close the issue after merging, and adding |
|
Hello @IrvingMg ,
I see. Let me retry it then and I will ocme back with the results. |
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
e951dd0 to
5b8f9d9
Compare
Description
Related issues
How was this tested?
Full testing requires an actual PR merge workflow run.
LLM usage
Claude Opus 4.6
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).