Remove unused test-only retrieval helpers#15
Open
vaishnavidesai09 wants to merge 1 commit into
Open
Conversation
Removes DenseRetriever.retrieve_dense_only() and retrieve_with_threshold(), which were only exercised by unit tests and never used in production code. Per maintainer decision in urrme#12, removing rather than documenting as public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
DenseRetriever.retrieve_dense_only()andHybridRetriever.retrieve_with_threshold()along with their unit tests. Both were only exercised by unit tests and never called from production code. Per maintainer decision in #12, removing rather than promoting to documented public API.Testing
make lintmake type-checkmake testmake eval-sample(retrieval scoring/ranking logic unchanged — only unused, untested-by-production methods removed)Ran locally: lint clean, mypy clean (48 files), full test suite 307 passed. Confirmed via grep that no other code references the removed methods.
Checklist