Skip to content

ci: harden trusted publish workflow#3871

Merged
JoviDeCroock merged 1 commit into
mainfrom
ci/disable-publish-workflow-cache
Jun 14, 2026
Merged

ci: harden trusted publish workflow#3871
JoviDeCroock merged 1 commit into
mainfrom
ci/disable-publish-workflow-cache

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Explicitly disables setup-node package-manager auto-caching in the trusted publishing workflow.
  • Removes existing publish-workflow dependency cache usage where present.
  • Pins external GitHub Actions in the trusted publish workflow to full commit SHAs, keeping the original tag as a comment breadcrumb.

Why

Trusted publishing/OIDC workflows should not restore shared dependency caches, and tag-based action references can be retargeted after compromise. The StepSecurity advisory for actions-cool/issues-helper is the concrete failure mode: tags were moved to an imposter commit, while full-SHA pinned workflows were unaffected.

Verification

  • Parsed the edited workflow YAML locally with PyYAML.
  • Re-scanned release workflows for actions/setup-node without package-manager-cache: false and for actions/cache usage.
  • Re-scanned trusted publish workflow uses: entries and confirmed all external actions are pinned to 40-character commit SHAs.

@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cb9bf38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 19, 2026

Copy link
Copy Markdown

Deploying urql with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb9bf38
Status:⚡️  Build in progress...

View logs

@JoviDeCroock JoviDeCroock changed the title ci: disable cache in publish workflow ci: harden trusted publish workflow May 19, 2026
@JoviDeCroock JoviDeCroock requested a review from kitten June 13, 2026 04:48
@JoviDeCroock JoviDeCroock force-pushed the ci/disable-publish-workflow-cache branch from 28cbd3a to 8996945 Compare June 13, 2026 05:39
@JoviDeCroock JoviDeCroock force-pushed the ci/disable-publish-workflow-cache branch from 8996945 to b93251a Compare June 14, 2026 06:49
@JoviDeCroock JoviDeCroock force-pushed the ci/disable-publish-workflow-cache branch from b93251a to cb9bf38 Compare June 14, 2026 06:49
@JoviDeCroock JoviDeCroock merged commit 4317f68 into main Jun 14, 2026
6 of 7 checks passed
@JoviDeCroock JoviDeCroock deleted the ci/disable-publish-workflow-cache branch June 14, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants