Change CMD to use JSON array#38
Merged
Merged
Conversation
When CMD is written as a shell string, Docker/Podman wraps it in /bin/sh -c "...". This means that when a `podman compose down` or `podman stop` is issued, the SIGTERM hits the outer /bin/sh where it is not handled, Docker/Podman then waits until stop_grace_period expires, where it then issues a SIGKILL. This has the possibility of being bad for the leveldb. As such, this fix allows for the SIGTERM to be properly handled by PID 1.
Owner
|
thanks for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CMD is written as a shell string, Docker/Podman wraps it in /bin/sh -c "...". This means that when a
podman compose downorpodman stopis issued, the SIGTERM hits the outer /bin/sh where it is not handled, Docker/Podman then waits until stop_grace_period expires, where it then issues a SIGKILL. This has the possibility of being bad for the leveldb. As such, this fix allows for the SIGTERM to be properly handled by PID 1.