mdns: fix mDNS peer discovery on systems without getaddrinfo mDNS resolution#1019
Open
tinnus-napbus wants to merge 1 commit into
Open
mdns: fix mDNS peer discovery on systems without getaddrinfo mDNS resolution#1019tinnus-napbus wants to merge 1 commit into
tinnus-napbus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Ames mDNS peer resolution by querying IPv4 A records through DNS-SD instead of re-resolving mDNS hostnames with
uv_getaddrinfo().Problem
mDNS never worked on my linux desktop machine.
The previous mDNS flow did this:
DNSServiceBrowse()discovered_ames._udppeersDNSServiceResolve()returned the peer host name and portuv_getaddrinfo()on the returned host name, forcingAF_INETOn systems where DNS-SD discovery worked but the host resolver was not able to resolve mDNS names through
getaddrinfo(), startup produced:This broke local peer discoverability even though DNS-SD had already resolved the service successfully.
Changes
uv_getaddrinfo()follow-up lookup frompkg/vere/mdns.cDNSServiceResolve(), query the peer host's IPv4 A record directly withDNSServiceQueryRecord()Why This Approach
Vere already relies on DNS-SD for service discovery. Querying the A record through the same DNS-SD stack is more robust than passing an mDNS-local hostname back through the host resolver and assuming
getaddrinfo()is mDNS-aware.This preserves IPv4-only behaviour while removing a platform-dependent failure mode.