jets: manual noun splitting instead of u3r_mean#1009
Draft
dozreg-toplud wants to merge 1 commit into
Draft
Conversation
efcf8a8 to
709fbad
Compare
Contributor
Author
|
Microbenchmarking showed order of magnitude improvement though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joemfb I tried replacing u3r_mean calls with explicit core splitting. Some observations:
+ridecall on Hoon source seems ~5% slower with explicit splitting.The way I implemented it was:
u3_nounoru3_weakand returnu3_weak:/jetsdirectory, turningu3r_meaninto composition of the function-like macros defined aboveAm I missing some way to make it more efficient?