Skip to content
This repository was archived by the owner on Jul 7, 2022. It is now read-only.

Add i18n feature#80

Open
kochizufan wants to merge 2 commits into
uphs-data-science:masterfrom
code4history:i18n_PR
Open

Add i18n feature#80
kochizufan wants to merge 2 commits into
uphs-data-science:masterfrom
code4history:i18n_PR

Conversation

@kochizufan

@kochizufan kochizufan commented Mar 19, 2020

Copy link
Copy Markdown
  • Add python-18n and pyyaml to dependencies
  • Wrap all strings by "i18n.t" function
  • Add locale resources for English and Japanese
  • Items in Japanese resources are partially translated

NOTE:

  • This change doesn't include "Language switching" function. Selected locale is hard-coded. I have no idea how to realize "Language switching", so I want to ask someone's help...
  • I'm not good translator and not medical expert, so I will ask someone who is good at translation and medical knowledge to finish Japanese translation later. So I will submit another PR to finish Japanese translation later.

* Add python-18n and pyyaml to dependencies
* Wrap all strings by "i18n.t" function
* Add locale respurces for English and Japanese
* Items in Japanese resources are partially translated

NOTE:
* This change doesn't include "Language switching" function. Selected locale is hard-coded. I have no idea how to realize "Language switching", so I want to ask someone's help...
* I'm not good translator and not medical expert, so I will ask someone who is good at translation and medical knowledge to finish Japanese translation later. So I will submit another PR to finish Japanese translation later.
@kochizufan

kochizufan commented Mar 19, 2020

Copy link
Copy Markdown
Author

Test failed..

==================================== ERRORS ====================================
_________________________ ERROR collecting test_app.py _________________________
ImportError while importing test module '/home/runner/work/chime/chime/test_app.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_app.py:1: in
import chime.app
app.py:7: in
import i18n
E ModuleNotFoundError: No module named 'i18n'

Does someone know how to avoid this error?
Adding "python-i18n" to Pipfile is not enough for testing?

[Edited] Solved by adding python-i18n to resources.txt

github-actions Bot pushed a commit that referenced this pull request Mar 23, 2020
Add prometheus+grafana to k8s; refactor other infra manifests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant