You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mdbecker this should allow deploying multiple streamlit containers (I couldn't tell via streamlit docs and code, whether their tornado implementation uses subprocesses. Guessing not, based on their emphasis on load balancers).
Once merged, I'll go ahead and deploy on the linode box (and then hopefully the devops team will swoop in and save us 😅)
I don't set up load balancers that often so any eyes on this would be helpful!
@machow I've never used this scaling ability of docker-compose, but I'm struggling to see how this could actually make multiple app instances available to nginx. If the port is constant, than either docker-compose would need to be round-robining the IP set on app somehow, or nginx would need to have some kind of capability to make its own DNS query and get back multiple IPs on a single A record -- but I doubt either of those setups are in place here (I could be wrong though)
I don't know that it's worth us diving too deep into docker-compose-based scaling strategies though if this isn't something we already know will work, k8s deploy should be ready soon and we know it will handle managing multiple app instances
I'm surprised docker even implemented a feature like this, but it turned out weirdly useful in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mdbecker this should allow deploying multiple streamlit containers (I couldn't tell via streamlit docs and code, whether their tornado implementation uses subprocesses. Guessing not, based on their emphasis on load balancers).
Once merged, I'll go ahead and deploy on the linode box (and then hopefully the devops team will swoop in and save us 😅)
I don't set up load balancers that often so any eyes on this would be helpful!