This repository was archived by the owner on Jul 7, 2022. It is now read-only.
Getting ready to deploy on k8s#40
Open
sam-writer wants to merge 3 commits into
Open
Conversation
- Changed: base image is slim-buster. This one line cuts the image size in half, from 1.37GB to 630MB - Changed: no longer reference script.sh, configs moved to .streamlit dir - Changed: CMD command doesn't specific server.port, which is already specified in ./streamlit/config.toml - Changed: add -q flag to pip install to make build logs shorter
Contributor
Author
|
FYI this DOES NOT block deploying on k8s, all these changes are cleanup/performance improvements, e.g. nice-to-haves |
themightychris
approved these changes
Mar 16, 2020
garysieling
pushed a commit
to garysieling/chime
that referenced
this pull request
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation to deploy on k8s (CodeForPhilly/civic-cluster#6), this PR:
Changed: moves configs from setup.sh into TOML files in
./.streamlit/to centralize themChanged: Dockerfile base image is slim-buster. This one line cuts the image size in half, from 1.37GB to 630MB
Changed: Dockerfile no longer reference script.sh, configs moved to .streamlit dir
Changed: Dockerfile CMD command doesn't specific server.port, which is already specified in ./streamlit/config.toml
Changed: Dockerfile add -q flag to pip install to make build logs shorter
Added: a .dockerignore to avoid copying unneeded files into the docker image