test: extend load coverage + add responsive e2e spec - #38
Merged
Conversation
added 2 commits
July 29, 2026 10:44
…occasion cards ruff failed the python job on tests/integration/test_load.py: importing the bearer_for fixture into the module that also names it as a parameter is F811, and that import also broke the block ordering (I001). Moving the re-export into a new tests/integration/conftest.py lets pytest discover the fixture with no import at the use site, which removes both errors without touching the module that defines it. The responsive e2e counted occasion radios once, which can land mid entrance animation and see only part of them. Verified against the live app that the picker really renders six radios in one radiogroup, so the assertion was right and the timing was not: it now scopes to the radiogroup and polls the count.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes two measured gaps in the test pyramid. Purely additive: no existing
test or source file is modified.
Load coverage (
tests/integration/test_load.py): the existingtest_concurrent_pipeline_generation_loadonly exercises the synchronous,direct-pipeline path. Adds two tests that drive the real FastAPI app
through the endpoints added this week:
test_concurrent_async_job_submission_load: 20 concurrentPOST /reels/jobssubmissions (5 workers), each polled to a terminalstate. Asserts every submission returns 202, every
job_idis unique,and every job reaches
done.test_concurrent_multitenant_isolation_under_load: 4 tenants + guestcreating reels concurrently (20 total ops, 5 workers). Asserts strict
per-tenant isolation holds under real concurrency via
GET /me/library(no cross-tenant or guest bleed), not just sequentially.
Tokens for the multitenancy test are minted with
test_api_multitenancy.py's ownbearer_forfixture (imported directly,not reinvented). Each concurrent submission uses its own fresh
TestClient(api.app)instance so the concurrency under test is the ASGIapp + shared storage, not the test harness itself.
Responsive e2e (
frontend/e2e/responsive.spec.ts, new file, mirrorsClaimScene's file of the same name): no horizontal overflow at
375/768/1280px through the full wizard, primary CTAs meet the 44px
tap-target minimum on mobile, the occasion cards collapse to a single
column on mobile (2/3 columns at tablet/desktop), and the result step's
player/provenance layout collapses to a single column below desktop width.
Auto-discovered by the existing
e2eCI job (npx playwright test,testDir: "./e2e") - no config changes needed.Test plan
lighthouse, demo-video, codeql x2, secret-scan)
not just pass trivially