[Required brand] decorators: add missing arguments on beforeModel#15
Merged
Conversation
OwenCoogan
approved these changes
Apr 29, 2026
nathalieArnoux
approved these changes
Apr 29, 2026
Comment on lines
+16
to
+28
| @@ -24,9 +25,9 @@ export function requiredBrand(brand: string, fallbackRoute: string) { | |||
| if ((getOwnConfig() as any).brand !== brand) { | |||
| this.router.transitionTo(fallbackRoute); | |||
| } else { | |||
| super.beforeModel() | |||
| super.beforeModel(...arguments); | |||
There was a problem hiding this comment.
question: did the parameter transform from transition to …arguments ? I'm probably missing something :/
aprentout
force-pushed
the
ap/fix-missing-params
branch
from
31793de to
d31ea84
Compare
phndiaye
approved these changes
Apr 29, 2026
edouardmisset
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #DRA-5001
What are the observable changes?
The goal of the PR is to avoid loosing beforeModel arguments when the
required-branddecorator is usedGood PR checklist