Upgrade Upjet to v1.9.0#86
Conversation
|
In another Environment I noticed the following error for SecretV2 Resources...
I am currently trying to figure out what is causing this |
|
@avarei I think that error looks like what was being seen from crossplane/crossplane-tools#103, which is now fixed and in the following upjet releases:
More details about this issue/fix in crossplane/crossplane-runtime#833 😅 |
Signed-off-by: Tim Geimer <32556895+Avarei@users.noreply.github.com>
|
Thank you @jbw976! Since the issue in crossplane-tools you mentioned is not yet resolved I experienced similar problems with the code generation as before in the latest upjet release. However by NOT following the upgrade instructions for upjet v1.8.0 and therefore NOT upgrading crossplane-tools to a version where the new k8s.io ptr methods are used I was able to get it working. |
|
Since this repository contains a lot of code generation, which results in many lines of code changes i want to give the reviewers an easy way to replicate my changes and validate the diff. I hope it's helpful 😃 |
erhancagirici
left a comment
There was a problem hiding this comment.
@avarei thanks for the PR! LGTM.
nit: triggering e2es as GH actions seems to be broken but I also triggered them locally for some resources. All good. That can be handled in a separate PR.
Description of your changes
Bump Upjet Dependency to v1.8.0 and in the process update angryjet (crossplane-tools) as described in the Release Notes of upjet v1.8.0.
All other changes are generated from
go mod tidyandmake reviewable.Fixes #85
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Additionally to
make reviewable testI ran the test specified in the Issue above usingmake e2eand i tested some of the examples in the examples dir.