Skip to content

Upgrade Upjet to v1.9.0#86

Merged
erhancagirici merged 1 commit into
upbound:mainfrom
avarei:bump/upjet
May 23, 2025
Merged

Upgrade Upjet to v1.9.0#86
erhancagirici merged 1 commit into
upbound:mainfrom
avarei:bump/upjet

Conversation

@avarei

@avarei avarei commented May 9, 2025

Copy link
Copy Markdown
Contributor

Description of your changes

Bump Upjet Dependency to v1.8.0 and in the process update angryjet (crossplane-tools) as described in the Release Notes of upjet v1.8.0.

All other changes are generated from go mod tidy and make reviewable.

Fixes #85

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Additionally to make reviewable test I ran the test specified in the Issue above using make e2e and i tested some of the examples in the examples dir.

@Upbound-CLA

Upbound-CLA commented May 9, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@avarei

avarei commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

In another Environment I noticed the following error for SecretV2 Resources...

cannot patch the managed resource via server-side apply: SecretV2.kv.vault.upbound.io "test" is invalid: [spec.initProvider.dataJsonSecretRef: Required value, <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]

I am currently trying to figure out what is causing this

@jbw976

jbw976 commented May 12, 2025

Copy link
Copy Markdown
Member

@avarei I think that error looks like what was being seen from crossplane/crossplane-tools#103, which is now fixed and in the following upjet releases:

More details about this issue/fix in crossplane/crossplane-runtime#833 😅

Signed-off-by: Tim Geimer <32556895+Avarei@users.noreply.github.com>
@avarei

avarei commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @jbw976!

Since the issue in crossplane-tools you mentioned is not yet resolved I experienced similar problems with the code generation as before in the latest upjet release.

However by NOT following the upgrade instructions for upjet v1.8.0 and therefore NOT upgrading crossplane-tools to a version where the new k8s.io ptr methods are used I was able to get it working.

@avarei avarei changed the title Upgrade Upjet to v1.8.0 Upgrade Upjet to v1.9.0 May 13, 2025
@avarei

avarei commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

Since this repository contains a lot of code generation, which results in many lines of code changes i want to give the reviewers an easy way to replicate my changes and validate the diff. I hope it's helpful 😃

git checkout d28b275b6e4978cd1ef58b5cac2d1f4d6f4ad40e
git fetch origin pull/86/head:pull/86
git diff --shortstat pull/86 # verify there is a diff
go get github.com/crossplane/upjet@v1.9.0
go mod tidy
make generate
git diff --shortstat pull/86 # verify there is no diff

@erhancagirici erhancagirici left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avarei thanks for the PR! LGTM.
nit: triggering e2es as GH actions seems to be broken but I also triggered them locally for some resources. All good. That can be handled in a separate PR.

@erhancagirici erhancagirici merged commit 00f846e into upbound:main May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SecretV2 fails to stay Synced

4 participants