Skip to content

Add URL Pattern test with an empty regexp group #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmisev merged 1 commit into from
Jun 18, 2026
Merged

Add URL Pattern test with an empty regexp group #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion test/wpt-urlpattern.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ namespace doctest {
// -----------------------------------------------------------------------------
// https://github.com/web-platform-tests/wpt/blob/master/urlpattern/urlpattern-constructor.any.js

TEST_SUITE("urlpattern_constructor") {
TEST_SUITE("urlpattern-constructor") {
TEST_CASE("Test unclosed token") {
CHECK_THROWS_AS(urlpattern{ upa::url("https://example.org/%(").to_string() },
upa::urlpattern_error);
Expand All @@ -131,6 +131,22 @@ TEST_SUITE("urlpattern_constructor") {
// }, `Test constructor with undefined`);
}

// -----------------------------------------------------------------------------
// https://github.com/web-platform-tests/wpt/blob/master/urlpattern/urlpattern-empty-regexp-group.html

TEST_SUITE("urlpattern-empty-regexp-group") {
TEST_CASE("URLPattern rejects an empty regexp group '()' with a TypeError") {
upa::urlpattern_init init;
init.pathname = "()";
CHECK_THROWS_AS(urlpattern{ init }, upa::urlpattern_error);
}
TEST_CASE("URLPattern accepts a non-empty regexp group '(a)'") {
upa::urlpattern_init init;
init.pathname = "(a)";
CHECK_NOTHROW(urlpattern{ init });
}
}

// -----------------------------------------------------------------------------
// https://github.com/web-platform-tests/wpt/blob/master/urlpattern/resources/urlpattern-hasregexpgroups-tests.js

Expand Down
Loading