Feature/hw-03 - #3
Open
uoles wants to merge 25 commits into
Open
Conversation
- Добавление исключения QuestionsFileLoadingException. - Работа с консолью вынесена в сервис ConsoleService. - Тесты для QuestionsDAO.
- Добавлены тесты.
- Изменения в структуре файлов.
- Использование библиотеки lombok.
- Файл настроек. - Java + Annotation-based конфигурация.
- Добавление своего баннера.
ydvorzhetskiy
approved these changes
Apr 23, 2019
| <properties> | ||
| <java.version>11</java.version> | ||
| <maven.compiler.source>${java.version}</maven.compiler.source> | ||
| <maven.compiler.target>${java.version}</maven.compiler.target> |
There was a problem hiding this comment.
Вах, как красиво) Но эо не обязательно добавлять со Spring Boot. Spring Boot parent содержит именно эти строчки от java.version
| <artifactId>junit</artifactId> | ||
| <version>4.12</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Если Вы используете jupiter (junit5), то junit4 в идеале быть не должно (только для легаси кода)
| <target>${java.version}</target> | ||
| <encoding>${encoding}</encoding> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
Вот это как раз уже есть в parent-e
|
|
||
| @SpringBootApplication | ||
| @PropertySource("classpath:application.yml") | ||
| @EnableConfigurationProperties({LocaleProperties.class, QuetionsProperties.class}) |
There was a problem hiding this comment.
А этотне обязательно добавлять, если Вы LocaleProperties делаете компонентом
| @Data | ||
| public class Question implements Serializable { | ||
|
|
||
| public static final String c_id = "id"; |
There was a problem hiding this comment.
- Так, для static-final переменных название должно быть C_ID
- Без этой константы прекрасно можно обойтись
| String answer = null; | ||
| boolean okAnswer = false; | ||
| int i = 0; | ||
| while (!okAnswer && i < 4) { |
| Question.c_answer3, | ||
| Question.c_answer4, | ||
| Question.c_trueAnswer | ||
| }); |
There was a problem hiding this comment.
Вот это можно аак раз переписать)
| \:\ /:/ / \:\ /:/ / \:\ \ \:\ \:\__\ \:\ \:\__\ | ||
| \:\/:/ / \:\/:/ / \:\ \ \:\ \/__/ \:\/:/ / | ||
| \::/ / \::/ / \:\__\ \:\__\ \::/ / | ||
| \/__/ \/__/ \/__/ \/__/ \/__/ No newline at end of file |
| @DisplayName("Класс LocalisationServiceImpl") | ||
| @RunWith(SpringRunner.class) | ||
| @SpringBootTest | ||
| @ActiveProfiles("ru") |
There was a problem hiding this comment.
Вот лучше проще профилями совсем ее пользоваться)
| () -> assertNotNull(value), | ||
| () -> assertEquals("При и вет - Привет", value) | ||
| ); | ||
| } |
There was a problem hiding this comment.
А вот логику тестирования, по-хорошему, надо проверить.
added 2 commits
April 23, 2019 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.