Skip to content

[WIP] additional front-end features#34

Open
gabriellesc wants to merge 1 commit into
masterfrom
ui-dev
Open

[WIP] additional front-end features#34
gabriellesc wants to merge 1 commit into
masterfrom
ui-dev

Conversation

@gabriellesc

@gabriellesc gabriellesc commented Aug 25, 2017

Copy link
Copy Markdown
Collaborator
  • checkbox range selection
  • table in-column searching
  • email templating with mangled applicant contract URL
    doesn't seem to be possible, since fetching the mangled contract URL would expose a vulnerability
    @michellemtchai what do you think?
  • session selection
  • modifying sessional pay

@michellemtchai

Copy link
Copy Markdown
Collaborator

@gabriellesc I can open up an admin only route GET /decision/:utorid/:position_id like before. This way the students gets their mangled routes and we get the readable routes for the admin.

@gabriellesc

Copy link
Copy Markdown
Collaborator Author

@michellemtchai what would that route return?

@michellemtchai

Copy link
Copy Markdown
Collaborator

@gabriellesc It would render the student-facing view. It's the same page the applicant sees when they click on the mangled link.

@gabriellesc

Copy link
Copy Markdown
Collaborator Author

@michellemtchai This would be for the purpose of inserting the mangled link into an email to send to people, not just for seeing the student-facing view

@michellemtchai

Copy link
Copy Markdown
Collaborator

@gabriellesc That can be an extra route or it can be part of the /offers fetch. Which do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants