Skip to content

fix: [ENG-424] Backport Docker dropdown spacer fix to 7.2#2640

Merged
limetech merged 2 commits into
7.2from
codex/backport-joly0-docker-dropdown-7.2
May 14, 2026
Merged

fix: [ENG-424] Backport Docker dropdown spacer fix to 7.2#2640
limetech merged 2 commits into
7.2from
codex/backport-joly0-docker-dropdown-7.2

Conversation

@elibosley
Copy link
Copy Markdown
Member

@elibosley elibosley commented May 14, 2026

Summary

  • Backports Joly0's Docker dropdown z-index/spacer fix to the 7.2 branch.
  • Preserves Joly0 as the author on both cherry-picked commits from Joly0:patch-1.
  • Adds the final spacer markup with docker-dropdown-spacer and aria-hidden="true".

Linear tracking

Credit

Original work by @Joly0 from https://github.com/Joly0/webgui/tree/patch-1.

Backported commits:

  • d464bda - Fix dropdown z-index
  • 6abd3fc - Update dropdown spacer element in docker.js

Validation

  • node --check emhttp/plugins/dynamix.docker.manager/javascript/docker.js

Joly0 added 2 commits May 14, 2026 12:07
Fixes clicking on a docker container when page has many containers the dropdown menu will be behind the footer and even outside the visible area because the scrollbar doesnt extend as far.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9c2389fd-1bf8-4b7a-874c-29fe917c204e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/backport-joly0-docker-dropdown-7.2

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.05.14.1608
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2640/webgui-pr-2640.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.docker.manager/javascript/docker.js

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2640, or run:

plugin remove webgui-pr-2640

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@elibosley elibosley changed the title [codex] Backport Docker dropdown spacer fix to 7.2 fix: Backport Docker dropdown spacer fix to 7.2 May 14, 2026
@elibosley elibosley added the 7.2 label May 14, 2026
@elibosley elibosley marked this pull request as ready for review May 14, 2026 16:11
@elibosley elibosley requested a review from limetech May 14, 2026 16:54
@elibosley elibosley changed the title fix: Backport Docker dropdown spacer fix to 7.2 fix: [ENG-424] Backport Docker dropdown spacer fix to 7.2 May 14, 2026
Copy link
Copy Markdown
Contributor

@limetech limetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@limetech limetech merged commit 135c521 into 7.2 May 14, 2026
5 checks passed
@limetech limetech deleted the codex/backport-joly0-docker-dropdown-7.2 branch May 14, 2026 21:24
@github-actions
Copy link
Copy Markdown

🧹 PR Test Plugin Cleaned Up

The test plugin and associated files for this PR have been removed from the preview environment.


🤖 This comment is automatically generated when a PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants