fix: land the 2026-07-01/02 review --max --fix hardening batch#195
Merged
Conversation
Two full-codebase audit passes (openswarm review --max --fix) applied working-tree fixes across ~120 files, plus 13 new test files. Themes: - taskState store: prototype-pollution-safe task map (null-prototype via schema preprocess), fail-closed on corrupt persisted state, Linear sync comment trust filter (marker/prefix + author allowlist; falls back to marker-only when the fetcher provides no author info), issueId mismatch guard, R5 reconcile extended to done->reopened transitions - telemetry: label sanitization (command/adapter/event) so dynamic strings cannot leak paths or prompts, installId shape validation, unref'd send timeout so fire-and-forget never keeps the process alive - bsDetector: hardcoded-secret pattern now catches env-fallback literals (process.env.X || "secret") instead of excluding any env-referencing line - adapters: readOnly CliRunOptions plumbed through the tool layer - assorted per-area fixes from the audit verdicts (locale key coverage, worker error surfacing in the fix loop, GraphQL resolvers, memory ops) Post-batch stabilization on top of the raw worker edits: 3 broken tests fixed (bsDetector expectation updated to the new intended behavior, telemetry mock uses a valid 21-char install id, sync-comment trust filter made compatible with the production fetcher's user:undefined) and 1 unused variable. Full suite 1378 passed, lint 0, tsc clean.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
/^Bearer\s+(.+)$/i backtracks polynomially on adversarial whitespace runs in the Authorization header. Replace with a regex-free slice/trim parse (same accepted forms: 'Bearer <token>' with space or tab).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two full-codebase audit passes (
openswarm review --max --fix, 2026-07-01 22:48 + 2026-07-02 09:47) left ~130 files of worker-applied fixes in the working tree. This lands them, stabilized and reconciled with v0.15.0 (clean auto-merge).Themes:
process.env.X || "secret")readOnlyCliRunOptions plumbed through the tool layerStabilization on top of the raw worker edits
user: undefined→ falls back to marker-only checks — otherwise hydration silently breaks in production)Verification
Full suite 1389 passed · oxlint 0 · tsc clean (after merging v0.15.0)
🤖 Generated with Claude Code