Skip to content

Add options to disable configuration guides on the main page#235

Open
Sarisan wants to merge 1 commit into
unmojang:masterfrom
Sarisan:feat/mainpage
Open

Add options to disable configuration guides on the main page#235
Sarisan wants to merge 1 commit into
unmojang:masterfrom
Sarisan:feat/mainpage

Conversation

@Sarisan

@Sarisan Sarisan commented Dec 20, 2025

Copy link
Copy Markdown
Contributor

Closes #230

@catfromplan9

catfromplan9 commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

You've mangled the syntax in config.go, please correct that and ensure the git diff only shows your lines being added there. Also, Shouldn't line 47 and line 116 be swapped with 48 and 117? As-is, this leaves two blank lines if client and server configuration guides were disabled which is not what we want. Otherwise, LGTM.

@Sarisan

Sarisan commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

You've mangled the syntax in config.go

I added the missing spaces to match with the rest of column, otherwise there will be no space between : and true.

@catfromplan9

Copy link
Copy Markdown
Contributor

LGTM!

@evan-goode evan-goode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the motivation and the patch, but I'm hesitant to add more options like this for configuring the web UI. The better approach IMO would be to allow more customization of the home page per #123 (comment).

I could see a WebHomePageTemplate and/or WebHomePageTemplateFile option where the user could specify their own home page layout. The default might be like

{{ template "login" . }}
{{ template "client-configuration" . }}
{{ template "server-configuration" . }}

and the admin could hide/rearrange the sections, or add more, by modifying the template.

In the meantime, we could add these options with the understanding they would likely be deprecated by a better system someday. But on the other hand, I'm leaning towards keeping this patch out of upstream, and if an admin wants to modify the home page, they can patch it themselves Suckless style.

@Sarisan

Sarisan commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

It's fine if it will be deprecated in future, just having it now is better than nothing. And I guess it's fine to keep it in pull requests so if anybody really needs it they can cherry pick and build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable configuration instructions on main page

3 participants