Add all missing members from 119th Congress#228
Conversation
|
@hugovk - do you or one of the other maintainers have availability to review and merge this PR in? There's currently a bunch of missing images for the 119th members. |
|
For some reason the CI didn't run, I'll give it a nudge. And if you can review, I can merge. Would you be interested in joining this project as maintainer? I've not really had time to look after this repo lately, plus I don't live in the US or use this data any more :) |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gh-pages #228 +/- ##
=========================================
Coverage 64.36% 64.36%
=========================================
Files 2 2
Lines 87 87
=========================================
Hits 56 56
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@hugovk sure! |
|
Great! Let me just check, any objections from the other members -- @konklone, @rshorey, @nickom -- of the https://github.com/orgs/unitedstates/teams/images team to add @mdrayer? |
|
Certainly open to it - @mdrayer are you a downstream user of the images as well? |
|
@konklone - yep, we are using the images API on a project. |
|
Nice - who's "we" in that? Do you have a link to the project? |
|
@konklone - We in this context is Forum One, the company I work for. The project is the Congressional District Health Dashboard. The repo is private, but we use the unitedstates APIs for our "Members of Congress" section of the site: https://www.congressionaldistricthealthdashboard.org/snapshots/district/5104?tab=facts |
|
@mdrayer Thanks for that. I've added you to the team for this org that should give you commit rights. Let me know if it's not working as expected, and thanks for being up for helping out! |
the United States. (In general, works of the federal government should satisfy
this criteria.)
I wrote my own script to collect images for all of the MOCs in the 119th Congress. I also found some inaccuracies in the GPO API data and have reached out to them with that information.
This PR also accidentally fixed several other issues like adding images for several MOCs who only had metadata.