Conversation
Ran 'npm audit fix --force' and then fixed the gulpfile.
* Update GPO (govinfo) and uscode.house.gov links. * Remove 'beta' from code.dccouncil.us links. * Remove legislink.org linker because the site is being discontinued. * Disable the LoC links for Statutes at Large volumes because it's not a deep link. * Other tweaks.
divergentdave
left a comment
divergentdave
left a comment
There was a problem hiding this comment.
Looks pretty good, thanks for working on this! (I haven't kicked the tires on it, as I'm writing this review from a bus) I think we might benefit from some tests to compare the output of fromId to the existing find method. The test could find a citation from a fixed string, take the id from that object, pass it to fromId, and then do a deep comparison of the two objects. They should be identical, save for the fields relating to the text searched by find. Thanks again!
|
Tests added! :) |
JoshData
force-pushed
the
updates
branch
4 times, most recently
from
6a5922e to
f020af9
Compare
|
It looks like nodeunit is permanently broken --- I can't get it to install on Travis, so the build is failing. But it works fine locally and tests are passing. Everyone OK to merge? |
|
I think the build is failing because |
|
Oh dear, it's using v0.10 now, the default is slightly older! |
The ejs package required by nodeunit failed to install on this old version. .travis.yml is revised to use the latest stable node version per https://docs.travis-ci.com/user/languages/javascript-with-nodejs/.
|
Nice catch! Ok finally got it working. |
3 participants
Hi all. I'm working on an update to https://uslaw.link/. Here are some updates to citation. The first few commits in this PR are just about updating packages with security issues. The last few add some minor new functionality.