fix(release): isolated venv for build/publish (PEP 668)#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release script tried to pip-install build+twine into the system/Homebrew Python, which PEP 668 blocks. Now it creates a throwaway venv and builds/publishes from there.
Summary by cubic
Build and publish now run from a temporary isolated venv, installing
pip,build, andtwinethere. This avoids PEP 668 blocks on Homebrew/externally managed Python and keeps the system Python untouched.Written for commit b2b4d28. Summary will update on new commits.