Skip to content

fix redis7.0 build; added test for dragonfly1.14, hugo, grafana10.2, imaginary1.2#276

Open
biancapetrea16 wants to merge 5 commits into
unikraft:mainfrom
biancapetrea16:biancapetrea16/add-catalog-examples
Open

fix redis7.0 build; added test for dragonfly1.14, hugo, grafana10.2, imaginary1.2#276
biancapetrea16 wants to merge 5 commits into
unikraft:mainfrom
biancapetrea16:biancapetrea16/add-catalog-examples

Conversation

@biancapetrea16

@biancapetrea16 biancapetrea16 commented Apr 24, 2026

Copy link
Copy Markdown

Redis 7.0:

  • changed unikraft, musl, lwip, and redis versions to stable

Dragonfly 1.14:

  • added a ping/pong integration test in the GitHub Actions workflow
  • added -M 512M to kraft run in CI to fix out-of-memory errors during boot

Grafana 10.2:

  • added an HTTP integration test using curl to verify the web server responds with status 200 or 302 on port 3000
  • added -M 2048M to kraft run to prevent out-of-memory errors when unpacking the large rootfs.
  • added if: matrix.plat == 'qemu' to the test step to bypass unsupported port forwarding on Firecracker (fc).

Hugo 0.122:

  • implemented an HTTP integration test using curl to verify the web server responds with status 200 or 302 on port 1313
  • increased the memory allocation to -M 1024M for the kraft run command to fix out-of-memory error
  • added if: matrix.plat == 'qemu' to bypass the test on Firecracker (fc) due to unsupported port forwarding.

Imaginary 1.2:

  • added a separate test job to the workflow that depends on the build job.
  • implemented an HTTP integration test using curl to ping the /health endpoint on port 8080, verifying that the microservice successfully boots and returns status 200
  • added if: matrix.plat == 'qemu' to the test step to bypass unsupported port forwarding on Firecracker (fc)

@biancapetrea16 biancapetrea16 marked this pull request as draft April 24, 2026 15:02
@biancapetrea16 biancapetrea16 changed the title fix(redis): update versions to stable and add run command fix redis7.0 build and add CI test for dragonfly1.14 Apr 25, 2026
@biancapetrea16 biancapetrea16 changed the title fix redis7.0 build and add CI test for dragonfly1.14 fix redis7.0 build and added test for dragonfly1.14, hugo, grafana10.2 May 8, 2026
@razvand razvand self-requested a review May 9, 2026 09:16
@razvand razvand self-assigned this May 9, 2026
@razvand razvand added the enhancement New feature or request label May 9, 2026

@razvand razvand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the Kraftfile in the redis/ directory in this commit? It should be removed?

Create a commit for each application you modify. You will have 4 commits in total.

Word your commits properly. Make sure you sign-off your commits. See instructions here. Read them many many times, be sure you observe all of them.

@biancapetrea16 biancapetrea16 force-pushed the biancapetrea16/add-catalog-examples branch 2 times, most recently from a8d47c3 to dfd1fdf Compare May 9, 2026 13:08
@biancapetrea16 biancapetrea16 changed the title fix redis7.0 build and added test for dragonfly1.14, hugo, grafana10.2 fix redis7.0 build; added test for dragonfly1.14, hugo, grafana10.2, imaginary1.2 May 9, 2026
@biancapetrea16 biancapetrea16 marked this pull request as ready for review May 9, 2026 13:10
@razvand razvand self-requested a review May 15, 2026 22:50

@razvand razvand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better.

Use comments in English throughout the workflows. Replace "instalez redis-tools" with "install redis-tools", and so on.

Remove trailing white spaces.

Start comment line with capital. That is, replace:

test(imaginary): fix out of memory and add HTTP integration test

with:

test(imaginary): Fix out of memory and add HTTP integration test

Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
@biancapetrea16 biancapetrea16 force-pushed the biancapetrea16/add-catalog-examples branch from dfd1fdf to cddb758 Compare May 16, 2026 08:04

@razvand razvand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

Also, after you address comments, please mark comments as solved by clicking on the Resolve conversation button and by re-requesting the review, by clicking the circular arrows link near the reviewer's name the PR screen on GitHub.

with:
name: index.unikraft.io/unikraft.org/dragonfly:1.14
push: true
push: true No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ending newline.

with:
name: index.unikraft.io/unikraft.org/imaginary:1.2
push: true
push: true No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ending newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants