fix redis7.0 build; added test for dragonfly1.14, hugo, grafana10.2, imaginary1.2#276
Conversation
razvand
left a comment
There was a problem hiding this comment.
Why is the Kraftfile in the redis/ directory in this commit? It should be removed?
Create a commit for each application you modify. You will have 4 commits in total.
Word your commits properly. Make sure you sign-off your commits. See instructions here. Read them many many times, be sure you observe all of them.
a8d47c3 to
dfd1fdf
Compare
razvand
left a comment
There was a problem hiding this comment.
Looks much better.
Use comments in English throughout the workflows. Replace "instalez redis-tools" with "install redis-tools", and so on.
Remove trailing white spaces.
Start comment line with capital. That is, replace:
test(imaginary): fix out of memory and add HTTP integration test
with:
test(imaginary): Fix out of memory and add HTTP integration test
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
Signed-off-by: Bianca Petrea <biancaiulia.petrea@gmail.com>
dfd1fdf to
cddb758
Compare
razvand
left a comment
There was a problem hiding this comment.
See my comments.
Also, after you address comments, please mark comments as solved by clicking on the Resolve conversation button and by re-requesting the review, by clicking the circular arrows link near the reviewer's name the PR screen on GitHub.
| with: | ||
| name: index.unikraft.io/unikraft.org/dragonfly:1.14 | ||
| push: true | ||
| push: true No newline at end of file |
| with: | ||
| name: index.unikraft.io/unikraft.org/imaginary:1.2 | ||
| push: true | ||
| push: true No newline at end of file |
Redis 7.0:
Dragonfly 1.14:
Grafana 10.2:
Hugo 0.122:
Imaginary 1.2: