No implicit rules in the segmenter#1444
Merged
Merged
Conversation
Member
markusicu
approved these changes
Jun 12, 2026
Member
There was a problem hiding this comment.
unrelated to this PR -- I have no idea what's changing in this file; it would benefit from more line breaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are expressible in the normal framework; their generation needlessly creates divergence between the standard and SegmenterDefault, and complicates usage (in particular, they mean the line segmenter is incorrect at the start of text and must be overridden to generate test cases!).