delete some unused UCD code#1436
Merged
Merged
Conversation
markusicu
force-pushed
the
delete-some-UCD
branch
from
d20e457 to
5f2fc3a
Compare
markusicu
requested review from
echeran,
eggrobin,
josh-hadley,
jowilco,
macchiati,
nedley and
roozbehp
nedley
reviewed
Jun 5, 2026
| } | ||
| } catch (final ArrayIndexOutOfBoundsException e) { | ||
| continue; | ||
| // continue; |
Contributor
There was a problem hiding this comment.
So this was working around an error before? If so and it’s no longer being worked around, I would argue in favor of removing the try block entirely.
Member
Author
There was a problem hiding this comment.
I didn't take a good look at this. It was and is catching/ignoring an exception.
IntelliJ shows lots of warnings and suggestions, and I chose to not ignore this one where it complained that the "continue" was redundant -- the loop continues anyway. I commented it out to keep the intent visible. IntelliJ is microscopically happier...
echeran
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards
Upgrade UnicodeProperty foundation #194
Approver: Feel free to merge on my behalf