Make cross-crate internal API style apply to component crates#8105
Merged
Conversation
Manishearth
approved these changes
Jun 19, 2026
Manishearth
left a comment
Manishearth
left a comment
Member
There was a problem hiding this comment.
This matches my read of the policy when it was proposed. Me applying it to utils crates was me extending the motivation to utils crates, not attempting to apply the policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was thinking about ICU4X component crates when I wrote this. It wasn't intended to apply to unstable crates (those versioned out of sync with ICU4X).
Changelog
N/A