currency: Move experimental currency formatting to legacy#8067
Open
younies wants to merge 2 commits into
Open
Conversation
Moving everything except mod.rs from currency to currency/legacy. Moved name_and_pattern from essentials.rs to legacy/mod.rs to avoid essentials depending on legacy code. Added TODO to each legacy file.
robertbastian
left a comment
robertbastian
left a comment
Member
There was a problem hiding this comment.
I'm not sure this is necessary, I believe the current code can be transformed into the new design fairly easily without rewriting it from scratch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
This PR moves the existing experimental currency formatting implementation to a
legacysubdirectory/module. This is in preparation for a new implementation based on the design at https://hackmd.io/@younies/number_formatter_4x.Changes:
mod.rs) fromcomponents/experimental/src/dimension/currencyto a newlegacysubdirectory.name_and_patternout ofessentials.rsintolegacy/mod.rsto ensure that data provider structs do not depend on legacy code.