Implement Currency Formatter API (New Design)#8045
Draft
younies wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
This PR implements the self-contained generic
CurrencyFormatterAPI (Option 1) as part of the experimental currency formatting architecture.Core Architecture & Typestate
ValueRepresentationTrait: Introduces a core trait to govern representation-specific internal data states.Decimal,Compact, andScientific(placeholder) marker types to enforce compile-time typestates.CurrencyFormatter<T: ValueRepresentation>which transparently adapts its internal storage based on the active typestate.Data Models & Payloads
DecimalCurrencyData: Added internal enum to handle bothStandard(CurrencyEssentialsV1) andLong(CurrencyExtendedDataV1+CurrencyPatternsDataV1) data requirements.CompactCurrencyData: Added internal enum integrating currency data withicu_decimalcompact payloads (DecimalCompactShortV1andDecimalCompactLongV1) and plural rules.Preferences & Configuration
CurrencyFormatterPreferencesandCompactCurrencyFormatterPreferencessupporting custom numbering systems.prefs_convert!rules for zero-friction conversion into underlyingDecimalFormatterPreferences,CompactDecimalFormatterPreferences, andPluralRulesPreferences.Polymorphic Constructors
try_new_short,try_new_narrow, andtry_new_longimplementations onCurrencyFormatter<Decimal>.try_new_short,try_new_narrow, andtry_new_longimplementations onCurrencyFormatter<Compact>.DataMarkerAttributesfromCurrencyCodeto properly resolve locale-specific long display names.Formatting Execution
format_fixed_decimal: Implements robust formatting logic returningimpl Writeable + Display.FixedDecimal::sign) and evaluatesPluralRulesacross all complex compact and long variants.Testing & Verification
Decimal/CompactxShort/Narrow/Long).$12,345.67,12,345.67 US dollars,$12K,12 thousand US dollars).