Skip to content

#71 Add network id to unicity id minting#72

Merged
b3y0urs3lf merged 2 commits into
mainfrom
issue-71
Jun 18, 2026
Merged

#71 Add network id to unicity id minting#72
b3y0urs3lf merged 2 commits into
mainfrom
issue-71

Conversation

@martti007

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors CertificationStatus from an enum to a final class to support custom statuses, adds network identifier validation to the mint transaction verification rules, and updates UnicityIdMintTransaction to include and serialize a networkId. The review feedback recommends using Locale.ROOT in CertificationStatus's equals and hashCode methods to prevent locale-sensitive bugs, and adding null checks for trustBase and genesis in CertifiedUnicityIdMintTransactionVerificationRule to avoid potential NullPointerExceptions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/org/unicitylabs/sdk/api/CertificationStatus.java
@martti007 martti007 requested a review from MastaP June 15, 2026 17:59
@MastaP MastaP linked an issue Jun 15, 2026 that may be closed by this pull request
@b3y0urs3lf b3y0urs3lf merged commit 46685bb into main Jun 18, 2026
1 check passed
@b3y0urs3lf b3y0urs3lf deleted the issue-71 branch June 18, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unicity ID mint transaction is missing network id

3 participants