fix: localnet scaffold failing end to end#14
Open
kkowalski-reef wants to merge 1 commit into
Open
Conversation
- **Netuid detection** — read from the `NetworkAdded` event instead of a before/after subnet-set diff, whose "before" came from a disk cache that survives localnet restarts (stale set → empty diff → abort). - **Admin freeze window** — zero `AdminFreezeWindow` up front; otherwise the first hyperparameter call dies with `AdminActionProhibitedDuringWeightsWindow` (exit 13). - **Dead hyperparameter** — drop `max_weight_limit`; removed from the runtime entirely (subtensor#2141), so its set call was a no-op everywhere and unused. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkAddedevent instead of a before/after subnet-set diff, whose "before" came from a disk cache that survives localnet restarts (stale set → empty diff → abort).AdminFreezeWindowup front; otherwise the first hyperparameter call dies withAdminActionProhibitedDuringWeightsWindow(exit 13).max_weight_limit; removed from the runtime entirely (subtensor#2141), so its set call was a no-op everywhere and unused.