feat(admin): close GAP btcli.sudo.senate-vote#12
Draft
unarbos wants to merge 134 commits into
Draft
Conversation
… mission Co-authored-by: Arbos <unarbos@users.noreply.github.com>
…rBase=main Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
…ngRef to root branch Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
…variants; preserve failure handoff Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
…gh-fast (others reject at API) Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
Co-authored-by: Arbos <unarbos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin raw --call senate-votealias that maps toSubtensorModule.voteyes/no,aye/nay,true/false,1/0) and proposal index lookup fromTriumvirate.Votingtests/parity/and updated admin command docs + parity matrix rowParity mapping
btcli.sudo.senate-voteGAP -> COVERED_E2Eagcli admin raw --call senate-vote --args '["0x<proposal_hash>","yes"]' --sudo-key //Alice --yes --output jsonVerification
SKIP_METADATA_FETCH=1 cargo build --release --bin agcli✅SKIP_METADATA_FETCH=1 cargo test --features e2e parse_senate_vote_args -- --nocapture✅SKIP_METADATA_FETCH=1 cargo test --features e2e --test parity -- --nocapture✅ (test runs and skips on runtimes without Triumvirate pallet)SKIP_METADATA_FETCH=1 cargo test --features e2e -- --nocaptureevents::tests::pretty_subtensor_variants_are_exhaustiveNotes
Triumviratemissing, so the new parity test intentionally exits early with a skip message in that environment while still validating the executable path and preserving the write-path assertion logic for governance-enabled runtimes.