World marker categories#437
Open
Ivinedra wants to merge 13 commits into
Open
Conversation
Add categorized, collapsible grouping for world marker UI and settings. Introduces WorldMarkerCategoryDefinitions (new) to define category order and assignments, updates MarkerControlWidget and SettingsWindowMarkerSettingsModule to build grouped UI from the registry, and adds collapsible group behavior and label prefixes to MenuPopup. Also updates templates/styles (markers_module.xml, _popup_menu.xml) and i18n entries for category labels and some marker names to support the new grouping and UI. These changes reorganize marker lists to improve discoverability and allow collapsing less-used groups.
Because VS is yelling at me.
This reverts commit ba0e5f1.
Adds support for the Elementals found in the various Eureka zones. Was one of the only markers we didn't have that AetherCompass used to provide so figured it'd be nice to port it over since it's fairly trivial. Also adds support for marker icons that arent 32x32, it'll still default to those values so it doesn't break any existing markers but they can be overridden in the specific marker factory with IconWidth and IconHeight. Had to implement this cause the icon that AC used (and by extension also this) is the buff icon so it's 24x32. <img width="185" height="135" alt="image" src="https://github.com/user-attachments/assets/b282ff8f-1cf2-4137-b00c-b4bea76a2eb3" />
This reverts commit e9d10d5.
Adds support for the Elementals found in the various Eureka zones. Was one of the only markers we didn't have that AetherCompass used to provide so figured it'd be nice to port it over since it's fairly trivial. Also adds support for marker icons that arent 32x32, it'll still default to those values so it doesn't break any existing markers but they can be overridden in the specific marker factory with IconWidth and IconHeight. Had to implement this cause the icon that AC used (and by extension also this) is the buff icon so it's 24x32. <img width="185" height="135" alt="image" src="https://github.com/user-attachments/assets/b282ff8f-1cf2-4137-b00c-b4bea76a2eb3" />
…/umbra into World-Marker-Categories
Bloodsoul
requested changes
Feb 19, 2026
Bloodsoul
left a comment
Bloodsoul
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the nice work. I added some remarks.
Contributor
There was a problem hiding this comment.
This fails for every marker without a set category.
| "OccultCoffers", | ||
| "OccultSurveyPointMarkers" | ||
| ] | ||
| }; |
Contributor
There was a problem hiding this comment.
I think it would be really nice to have each marker put their own category in there. Maybe something like it is done with the toolbar widgets https://github.com/una-xiv/umbra/blob/main/Umbra/src/Toolbar/Widgets/Library/Accessibility/AccessibilityWidget.cs#L7
And if a Marker does not define a category, it goes in "General" automatically. This also solves the problem, that we cannot know what markers someone has installed via custom plugins.
| "Markers.PartyMembers.Config.ShowName.Description": "Whether to show the party member names on the world markers.", | ||
| "Markers.PartyMembers.Config.IconType.Name": "Job icon type", | ||
| "Markers.PartyMembers.Config.IconType.Description": "The type of icon that is used on the world marker. Only applicable if 'Show party member icons' is enabled.", | ||
| "Markers.EurekaCoffers.Name": "Eureka Bunny Coffers", |
Contributor
There was a problem hiding this comment.
I wouldn't mind repeating the category in the names. It's also better to have them here when someone renames the categories in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for world marker categories, both in the widget and in the settings menu: