Ts and update - #1
Open
mariannefeng wants to merge 14 commits into
Open
Conversation
… statuscodes. Still need to update readme and fix typescript errors for resourceRouter and oauth
…lving errors inside of oauth lib
…d named exports for the 3 'submodules'
shankj3
approved these changes
May 14, 2020
shankj3
left a comment
shankj3
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for all the beautiful documentation!
| return normalizeUrl( | ||
| path.replace(beginningSlashes, ''), | ||
| { | ||
| stripProtocol: true, | ||
| stripHash: true, | ||
| removeQueryParameters: true, |
Collaborator
There was a problem hiding this comment.
just question -- why are we keeping in query params here?
Collaborator
Author
There was a problem hiding this comment.
removeQueryParameters doesn't take in a boolean, it takes in a string regex. This line wasn't doing anything, so I took it out.
| export const authorizePatch = getPhinClient(HTTPMethod.PATCH); | ||
|
|
||
| //we have to do this for delete because when delete returns 204 no content, phin client crashes | ||
| //waiting on PR https://github.com/ethanent/phin/pull/38 |
| throw new Error('Invalid token response'); | ||
| } | ||
|
|
||
| // set token expiration to be 2 minutes before stated expiration |
|
|
||
| type AsyncFunction = () => Promise<String> | ||
|
|
||
| export function jwt(oauthKey: string): AsyncFunction { |
Collaborator
There was a problem hiding this comment.
if there aren't comments here, do you still get the tooltip highlights on IDEs that render the jsdoc? i do like when they do that
Collaborator
Author
There was a problem hiding this comment.
oh...no tooltip on hover yeah. I like it more too though! I'll move the comment I already wrote over the jwt/clientCredentials functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.