Mu irte for action item form - #16
Open
jebeni777 wants to merge 8 commits into
Open
Conversation
Mostly PropTypes and properties of Grid errors
Deploying development
…portal into MUIrte-for-ActionItemForm
Added MUI Rich Text editor to ActionItemForm and ActionItemModal for assignment descriptions and created defaultTheme for MUI theme in the style pages. Added Rich Text rendering to ViewMoreModal and ActionItemCard making backward compatible and adjusting the styles for AssignmentList to accomodate changes.
…p/participant-portal into MUIrte-for-ActionItemForm
shankj3
requested changes
Nov 23, 2020
shankj3
left a comment
shankj3
left a comment
Collaborator
There was a problem hiding this comment.
Few cleanup comments / questions. This is mostly good to go!
| ]} | ||
| /> | ||
| </MuiThemeProvider> | ||
| {/* <TextField |
Collaborator
There was a problem hiding this comment.
You can take out the old commented code now that the new code works!
| multiline | ||
| rows={4} | ||
| /> | ||
| <MuiThemeProvider theme={defaultTheme}> |
Collaborator
There was a problem hiding this comment.
do we want to make this backwards compatible as well? if so, can do the ternary here too
| {isCaseNote | ||
| ? renderRichText(description) | ||
| : renderReadOnlyTextField(description)} | ||
| {renderRichText(description)} |
Collaborator
There was a problem hiding this comment.
just to confirm - this ViewMoreModal isn't used anywhere else, yeS?
| <Grid item className={classes.descriptionStyle} zeroMinWidth> | ||
| <Typography noWrap variant="body1" style={{ fontSize: '14px' }}> | ||
| {description} | ||
| {description[0] === '{' ? renderRichText(description) : description} |
Collaborator
There was a problem hiding this comment.
i would add a code comment above, just saying that this is for backwards compatibility
Added more backward compatability between TextField and RichText
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Rich Text Editor for Assignment
Added MUI-rte to ActionItemForm and ActionItemModal for assignment descriptions. Created defaultTheme for MUITheme in corresponding styles.js pages. Added Rich Text rendering on ActionItemCard and ViewMoreModal making them backwards compatible and adjusting corresponding styles.js pages to accommodate changes.
Fixes Issue #12