Fix SwiftUI accessibility, structure, and Swift 6 readiness - #2
Open
umzcio wants to merge 8 commits into
Open
Conversation
The macos-14 image is deprecated and its Xcode tops out at Swift 5
("SWIFT_VERSION '6.0' is unsupported"), so this branch's strict Swift 6
migration could never build there. macos-26 ships Xcode 27, which covers
SWIFT_DEFAULT_ACTOR_ISOLATION (Swift 6.2+) and still builds the Swift 5
code on master.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
deinit hardening: replace MainActor.assumeIsolated in all nine deinits with direct nonisolated teardown. assumeIsolated traps if the last reference is released off the main thread (realistic via escaping async closures); the operations themselves (Timer.invalidate, removeObserver, DispatchSource cancel, NSEvent.removeMonitor) are nonisolated APIs, and deinit has exclusive access to stored properties. Timers and the escape-monitor token gain nonisolated(unsafe) — all live access stays on the main actor; the annotation exists solely for deinit. SourceEditorView's deinit inlines the nonisolated subset of teardown() (delegate is weak, nil-outs pointless in deinit); dismantleNSView still runs the full teardown on the main actor. Comment restoration: the ContentView decomposition dropped several regression-guard comments while keeping the code they explain. Restored: .id(document.id) stale-outline rationale (NormalContentView), scroll-Y snapshot + Plan 003 per-document diagram-tick keying (MarkdownTextView), Reduce Motion grouped fade (WelcomeView), drop recursion/cap/toast rationale (DropHandler), minimap wiring + contentVersion proxy rationale (SourceEditorWithMinimap), split-pane header doc (SplitPaneHeader). Build clean, 45/45 tests pass, launch smoke-tested. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing