Skip to content

LIBWEB-6764. Remove dead computer availability code causing crash in … #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfjrl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LIBWEB-6764. Remove dead computer availability code causing crash in … #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 1 addition & 43 deletions monitors/blueprints/frontend/static/js/mckeldin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const CONFIG = {
endpoints: {
hours: "/api/libtools/mckeldin/hours/today",
rooms: "/api/libtools/mckeldin/availability",
computers: "/monitors/api/workstations-mckeldin.json",
equipment: "/alma-service/equipment",
},
equipmentIds: {
Expand All @@ -19,7 +18,7 @@ const CONFIG = {
const DataService = {
/**
* Fetch data from API or use mock data in development
* @param {string} dataType - Type of data to fetch (hours, rooms, computers)
* @param {string} dataType - Type of data to fetch (hours, rooms)
* @returns {Promise<Object>} - The fetched or mock data
*/
async fetchData(dataType) {
Expand Down Expand Up @@ -289,44 +288,6 @@ const UIService = {
barEl.style.width = `${progressBarValue}%`;
},

/**
* Update library available computers display
* @param {Object} data - Library computers data
*/
updateLibraryComputers(data) {
if (!data) return;

// First floor
this.updateComputerSection("info-1st", data.MCK1F);

// Second floor
this.updateComputerSection("info-2nd", data.MCK2F);
},

/**
* Helper function to update a computer section
* @param {string} sectionId - HTML element ID for the section
* @param {Object} floorData - Floor data object
*/
updateComputerSection(sectionId, floorData) {
const section = document.getElementById(sectionId);
const availableEl = section.querySelector("#available-count");
const totalEl = section.querySelector("#total-count");
const decoEl = section.querySelector("#content-deco");
const barEl = section.querySelector("span.status-bar");

availableEl.innerHTML = floorData.available;
totalEl.innerHTML = floorData.total;
decoEl.innerHTML = "/";

// update the availability bar
let progressBarValue = (floorData.available / floorData.total) * 100;
if (progressBarValue > 100) {
progressBarValue = 100;
}
barEl.style.width = `${progressBarValue}%`;
},

/**
* Update equipment availability display
* @param {Object} data - Aggregated equipment data
Expand Down Expand Up @@ -430,9 +391,6 @@ const LibraryApp = {
const roomsData = await DataService.fetchData("rooms");
UIService.updateLibraryRooms(roomsData);

const computersData = await DataService.fetchData("computers");
UIService.updateLibraryComputers(computersData);

const equipmentData = await DataService.fetchEquipmentData();
UIService.updateEquipmentAvailability(equipmentData);

Expand Down